Update CIS RHEL requirements for log files permissions #10241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CIS requirements to set on log files properties checks permissions in RHEL7 and RHEL8 while in RHEL9 also checks owner and group-owner. The rsyslog_files_permissions rule was also listed in 4.2.1.3 requirement for RHEL7 and 4.2.1.4 requirement for RHEL8. This was not correct and was fixed in this commit.
marcusburghardt
added
RHEL
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 03125e9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.7% (0.0% change). View more on Code Climate. |
|
/retest |
jan-cerny
approved these changes
Feb 22, 2023
marcusburghardt
added
the
Update Profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
CIS requirements to set on log files properties checks permissions in RHEL7 and RHEL8 while in RHEL9 also checks owner and group-owner.
Also, the
rsyslog_files_permissionsrule was also listed in 4.2.1.3 requirement for RHEL7 and 4.2.1.4 requirement for RHEL8. This is not correct and is fixed by this PR.Rationale:
Better CIS coverage for RHEL products.