Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce rule to remove nginx package #10291

Merged

Conversation

marcusburghardt
Copy link
Member

Description:

The CIS requirement to remove web servers in RHEL8 and RHEL9 also asks to remove the nginx package.
The CIS requirements were also updated in the respective control files to include the new templated rule.

Rationale:

Better CIS coverage for RHEL.

@marcusburghardt marcusburghardt added New Rule Issues or pull requests related to new Rules. RHEL9 Red Hat Enterprise Linux 9 product related. RHEL8 Red Hat Enterprise Linux 8 product related. CIS CIS Benchmark related. labels Mar 6, 2023
@marcusburghardt marcusburghardt added this to the 0.1.67 milestone Mar 6, 2023
@marcusburghardt marcusburghardt requested a review from a team as a code owner March 6, 2023 15:33
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

The CIS requirement to remove web servers in RHEL8 and RHEL9 also asks
to remove the nginx package. The respective requirements were updated to
include the new templated rule.
@codeclimate
Copy link

codeclimate bot commented Mar 6, 2023

Code Climate has analyzed commit 5197496 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.7% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Mar 6, 2023
@Mab879 Mab879 merged commit 7f094ff into ComplianceAsCode:master Mar 6, 2023
@marcusburghardt marcusburghardt deleted the cis_package_nginx_removed branch March 7, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. New Rule Issues or pull requests related to new Rules. RHEL8 Red Hat Enterprise Linux 8 product related. RHEL9 Red Hat Enterprise Linux 9 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants