vlock_installed: apply only to platform machine

[candrews]

Description:

vlock_installed: apply only to platform machine

Rationale:

The 'Check that vlock is installed to allow session locking' rule should not apply to containers.

Review Hints:

With this change applied, oscap-podman ubuntu:20.04 xccdf eval --report report.html --profile xccdf_org.ssgproject.content_profile_stig /usr/share/xml/scap/ssg/content/ssg-ubuntu2004-ds.xml should yield a report indicating that the "Check that vlock is installed to allow session locking" rule is "Not Applicable"

[openshift-ci]

Hi @candrews. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

ol8 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[github-actions]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

bash remediation for rule 'xccdf_org.ssgproject.content_rule_vlock_installed' differs.
--- xccdf_org.ssgproject.content_rule_vlock_installed
+++ xccdf_org.ssgproject.content_rule_vlock_installed
@@ -1,4 +1,10 @@
+# Remediation is applicable only in certain platforms
+if [ ! -f /.dockerenv ] && [ ! -f /run/.containerenv ]; then
 
 if ! rpm -q --quiet "kbd" ; then
 yum install -y "kbd"
 fi
+
+else
+ >&2 echo 'Remediation is not applicable, nothing was done'
+fi

ansible remediation for rule 'xccdf_org.ssgproject.content_rule_vlock_installed' differs.
--- xccdf_org.ssgproject.content_rule_vlock_installed
+++ xccdf_org.ssgproject.content_rule_vlock_installed
@@ -2,6 +2,7 @@
 package:
 name: kbd
 state: present
+ when: ansible_virtualization_type not in ["docker", "lxc", "openvz", "podman", "container"]
 tags:
 - DISA-STIG-OL08-00-020043
 - enable_strategy

Platform has been changed for rule 'xccdf_org.ssgproject.content_rule_vlock_installed'
--- xccdf_org.ssgproject.content_rule_vlock_installed
+++ xccdf_org.ssgproject.content_rule_vlock_installed
@@ -1 +1 @@
-
+cpe:/a:machine

[codeclimate]

Code Climate has analyzed commit 6f25143 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.7% (0.0% change).

View more on Code Climate.

[jan-cerny]

The Automatus's bot CI job fail is expected because the rule vlock_installed ins't a part of RHEL 8 and RHEL 9 benchmarks (prodtype: ol8,sle12,sle15,ubuntu2004).