Enable rsyslog_filecreatemode rule for RHEL #10328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RHEL7 the remediation was reporting "invalid arithmetic operator". This was fixed.
This rule covers the 4.2.1.4 CIS requirement for RHEL8 and RHEL9, and the 4.2.1.3 CIS requirement for RHEL7. The prodtype and references paramenters were updated and identifiers for RHEL were included. The CIS control files were updated.
Ansible remediation was included, aligned to the Bash remediation.
marcusburghardt
added
RHEL
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
It is not necessary to restart the rsyslog for testing purposes since the OVAL checks the configuration files content regardless of the service state.
marcusburghardt
force-pushed
the
cis_rsyslog_filecreatemode
branch
from
6f635c8
to
31bd17e
Compare
|
Automatus tests are failing because the the service can't be restarted with systemctl in the test containers. |
|
Code Climate has analyzed commit 31bd17e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.7% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
[jcerny@thinkpad scap-security-guide{pr/10328}]$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel8 rsyslog_filecreatemode
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2023-03-13-1457/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_rsyslog_filecreatemode
INFO - Script filecreatemode_0600.pass.sh using profile (all) OK
INFO - Script filecreatemode_0601.fail.sh using profile (all) OK
INFO - Script filecreatemode_0640.pass.sh using profile (all) OK
INFO - Script filecreatemode_0755.fail.sh using profile (all) OK
INFO - Script filecreatemode_duplicate.fail.sh using profile (all) OK
INFO - Script filecreatemode_missing.fail.sh using profile (all) OK
[jcerny@thinkpad scap-security-guide{pr/10328}]$ python3 tests/automatus.py rule --remediate-using ansible --libvirt qemu:///system ssgts_rhel8 rsyslog_filecreatemode
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2023-03-13-1503/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_rsyslog_filecreatemode
INFO - Script filecreatemode_0600.pass.sh using profile (all) OK
INFO - Script filecreatemode_0601.fail.sh using profile (all) OK
INFO - Script filecreatemode_0640.pass.sh using profile (all) OK
INFO - Script filecreatemode_0755.fail.sh using profile (all) OK
INFO - Script filecreatemode_duplicate.fail.sh using profile (all) OK
INFO - Script filecreatemode_missing.fail.sh using profile (all) OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This rule covers the
4.2.1.4CIS requirement for RHEL8 and RHEL9, and the4.2.1.3CIS requirement for RHEL7.The
prodtypeandreferencesparameters were updated andidentifiersfor RHEL were included.The CIS control files were updated and finally an Ansible remediation was included.
Rationale: