Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make accounts_password_last_change_is_in_past not applicable to containers #10339

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • add machine applicability platform to rule accounts_password_last_change_is_in_past

Rationale:

The unix:shadow OVAL probe used in the OVAL check is can't be used in offline mode. Moreover, general applicability of such a rule to containers is debatable.

Fixes: #10212

@vojtapolasek vojtapolasek added bugfix Fixes to reported bugs. Update Rule Issues or pull requests related to Rules updates. labels Mar 16, 2023
@vojtapolasek vojtapolasek added this to the 0.1.67 milestone Mar 16, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Mar 16, 2023

Code Climate has analyzed commit f41ea30 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.7% (0.0% change).

View more on Code Climate.

@openshift-ci
Copy link

openshift-ci bot commented Mar 16, 2023

@vojtapolasek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-e8 f41ea30 link true /test e2e-aws-rhcos4-e8
ci/prow/e2e-aws-rhcos4-high f41ea30 link true /test e2e-aws-rhcos4-high
ci/prow/e2e-aws-rhcos4-moderate f41ea30 link true /test e2e-aws-rhcos4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jan-cerny jan-cerny self-assigned this Mar 20, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping CentOS Stream 8 job because of the ongoing incident https://status.testing-farm.io/issues/2023-03-16-centos-stream-8/

@jan-cerny jan-cerny merged commit 7622921 into ComplianceAsCode:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accounts_password_last_change_is_in_past test scenarios results in unknown for containers
2 participants