fix loops within ansible template for rsyslog_files #10349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get rid of map functions also previous implementation did not account for the fact that variable created in loops have results stored in ".results" data structure
vojtapolasek
added
bugfix
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 48c3b99 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.8% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
I was able to reproduce the issue #10170 in a RHEL 7.9 machine with the 20230228.1 compose - both the host and the guest are the same RHEL 7.9 version.
[root@cisco-c210-01 content]# python3 tests/automatus.py rule --libvirt qemu:///system test_suite_vm --remediate-using ansible rsyslog_files_groupownership
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /root/content/logs/rule-custom-2023-03-24-0400/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership
INFO - Script rainer_include_incorrect_attr.fail.sh using profile (all) OK
ERROR - Rule evaluation resulted in fail, instead of expected pass during final stage
ERROR - The check after remediation failed for rule 'xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership'.
INFO - Script rainer_include_correct_attr.pass.sh using profile (all) OK
INFO - Script legacy_include_incorrect_attr.fail.sh using profile (all) OK
ERROR - Rule evaluation resulted in fail, instead of expected pass during final stage
ERROR - The check after remediation failed for rule 'xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership'.
INFO - Script rainer_include_multiline_incorrect_attr.fail.sh using profile (all) OK
ERROR - Rule evaluation resulted in fail, instead of expected pass during final stage
ERROR - The check after remediation failed for rule 'xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership'.
INFO - Script legacy_correct_attr.pass.sh using profile (all) OK
INFO - Script mixed_incorrect_attr_rainer.fail.sh using profile (all) OK
INFO - Script mixed_correct_attr.pass.sh using profile (all) OK
INFO - Script mixed_incorrect_attr_cloudinit.fail.sh using profile (all) OK
INFO - Script mixed_include_incorrect_attr_legacy.fail.sh using profile (all) OK
ERROR - Rule evaluation resulted in fail, instead of expected pass during final stage
ERROR - The check after remediation failed for rule 'xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership'.
INFO - Script mixed_incorrect_attr_legacy.fail.sh using profile (all) OK
INFO - Script rainer_include_multiline_correct_attr.pass.sh using profile (all) OK
INFO - Script mixed_include_incorrect_attr_rainer.fail.sh using profile (all) OK
ERROR - Rule evaluation resulted in fail, instead of expected pass during final stage
ERROR - The check after remediation failed for rule 'xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership'.
INFO - Script mixed_include_correct_attr.pass.sh using profile (all) OK
INFO - Script legacy_incorrect_attr.fail.sh using profile (all) OK
INFO - Script legacy_include_correct_attr.pass.sh using profile (all) OK
INFO - Script rainer_correct_attr.pass.sh using profile (all) OK
INFO - Script rainer_incorrect_attr.fail.sh using profile (all) OK
I can confirm that with this PR the test fails are fixed and they all pass:
[root@cisco-c210-01 content]# python3 tests/automatus.py rule --libvirt qemu:///system test_suite_vm --remediate-using ansible rsyslog_files_groupownership
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /root/content/logs/rule-custom-2023-03-24-0438/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_rsyslog_files_groupownership
INFO - Script mixed_incorrect_attr_rainer.fail.sh using profile (all) OK
INFO - Script legacy_incorrect_attr.fail.sh using profile (all) OK
INFO - Script rainer_incorrect_attr.fail.sh using profile (all) OK
INFO - Script mixed_include_correct_attr.pass.sh using profile (all) OK
INFO - Script legacy_include_correct_attr.pass.sh using profile (all) OK
INFO - Script legacy_correct_attr.pass.sh using profile (all) OK
INFO - Script mixed_include_incorrect_attr_legacy.fail.sh using profile (all) OK
INFO - Script mixed_include_incorrect_attr_rainer.fail.sh using profile (all) OK
INFO - Script rainer_include_correct_attr.pass.sh using profile (all) OK
INFO - Script rainer_include_multiline_incorrect_attr.fail.sh using profile (all) OK
INFO - Script rainer_include_incorrect_attr.fail.sh using profile (all) OK
INFO - Script mixed_incorrect_attr_legacy.fail.sh using profile (all) OK
INFO - Script rainer_correct_attr.pass.sh using profile (all) OK
INFO - Script legacy_include_incorrect_attr.fail.sh using profile (all) OK
INFO - Script rainer_include_multiline_correct_attr.pass.sh using profile (all) OK
INFO - Script mixed_correct_attr.pass.sh using profile (all) OK
INFO - Script mixed_incorrect_attr_cloudinit.fail.sh using profile (all) OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
Review Hints:
see the issue fixed by this PR