Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule package_nfs-kernel-server_removed for Ubuntu CIS #10358

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

dodys
Copy link
Contributor

@dodys dodys commented Mar 24, 2023

Description:

  • Add new rule package_nfs-kernel-server_removed. I know that we already have package_nfs-utils_removed but since this is quite the package name difference even though the source package name is the same nfs-utils, what people install or uninstall in ubuntu is the binary package name nfs-kernel-server

Rationale:

  • This relates to CIS on both Ubuntu 20.04 and 22.04.

@dodys dodys requested a review from a team as a code owner March 24, 2023 11:25
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2004 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added this to the 0.1.67 milestone Mar 24, 2023
@Mab879 Mab879 self-assigned this Mar 24, 2023
@Mab879 Mab879 added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. CIS CIS Benchmark related. labels Mar 24, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 24, 2023

Code Climate has analyzed commit ff3ecf4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.8% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Mar 24, 2023

Automatus failures are expected due the prodtype of this rule.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Mab879 Mab879 merged commit 2523d19 into ComplianceAsCode:master Mar 24, 2023
@dodys dodys deleted the nfs-kernel-server branch April 17, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. New Rule Issues or pull requests related to new Rules. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants