OCPBUGS-8358: enable_fips_mode: Make it clear that RHCOS can't be FIPS-enabled post-install #10363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S-enabled post-install The description is valid for RHEL, but not for RHCOS and was sending users in the wrong direction.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
Mab879
added
OpenShift
|
Code Climate has analyzed commit 9ca2950 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.9% (0.0% change). View more on Code Climate. |
rhmdnd
reviewed
Mar 29, 2023
| for the cluster. The flag <pre>fips: true</pre> must be enabled | ||
| at install time in the <pre>install-config.yaml</pre> file. If | ||
| this rule fails on an installed cluster, then this is a permanent | ||
| finding and cannot be fixed. |
There was a problem hiding this comment.
Short of redeploying the cluster with fips: true
rhmdnd
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The description is valid for RHEL, but not for RHCOS and was sending
users in the wrong direction.
Rationale:
Review Hints: