-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requirements files for python dependencies #10487
Conversation
This overlaps with #10474 - but ideally at the end of the process all dependencies will either be in a bindep or requirements file. |
ef10d5b
to
810c932
Compare
Would it be possible to use this in https://github.com/ComplianceAsCode/content/blob/master/.github/workflows/gate.yaml? i.e. to have the dnf-powered dep install stage followed by pip where it is applicable? |
I'd just add that this stage could be optimized into |
You mean using the requirements.txt file during the python package install process? diff --git a/.github/workflows/gate.yaml b/.github/workflows/gate.yaml
index ee43e6e2e4..0696d1bd46 100644
--- a/.github/workflows/gate.yaml
+++ b/.github/workflows/gate.yaml
@@ -60,7 +60,7 @@ jobs:
- name: Install Deps
run: apt-get install -y ansible-lint bats check cmake expat libopenscap8 libxml2-utils ninja-build python3-github python3-jinja2 python3-setuptools python3-pip python3-pytest python3-pytest-cov xsltproc
- name: Install deps python
- run: pip3 install ruamel.yaml yamlpath pyyaml==5.4.1
+ run: pip3 install -r requirements.txt
- name: Checkout
uses: actions/checkout@v2
- name: Build |
810c932
to
a469c02
Compare
a469c02
to
9273b02
Compare
Looks like we have some issues where the workflows can't find the requirements files. |
It may be that checking out the repo first and then to download deps (i.e. right before building the content) could help ;-) |
9273b02
to
8cd90c8
Compare
8cd90c8
to
b80132d
Compare
After I looked a little closer I saw that checkout was happening right after the pip install step. Thanks! |
b80132d
to
731c5cd
Compare
Rebasing to pull in #10540 |
Clean CI run now that we're past the testing farm issue (for now). Should be good for another round of reviews. |
@rhmdnd This looks good to me. Can you please rebase to fix the conflicts. |
This commit adds two separate requirements files that you can feed into pip for installing python dependencies. This makes it easier for contributors to install dependencies by having them isolated to a couple specific files, instead of having to reference build documentation.
731c5cd
to
e014370
Compare
Code Climate has analyzed commit e014370 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.8% (0.0% change). View more on Code Climate. |
This commit adds two separate requirements files that you can feed into
pip for installing python dependencies.
This makes it easier for contributors to install dependencies by having
them isolated to a couple specific files, instead of having to reference
build documentation.