Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce file_permissions_audit_configuration rule #10489

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

marcusburghardt
Copy link
Member

Description:

There were already templated rules for Audit Configuration files ownership and group-ownership, but not for permissions.
This commit includes the file_permissions_audit_configuration rule using the file_permissions template.

Rationale:

Better CIS coverage for RHEL

There were already templated rules for Audit Configuration files
ownership and group-ownership, but not for permissions. This commit
includes this rule using the file_permissions template and based on the
other two rules mentioned earlier.
This requirements is about Audit Configuration files permissions, which
is now satistifed by the file_permissions_audit_configuration rule.
@marcusburghardt marcusburghardt added New Rule Issues or pull requests related to new Rules. RHEL9 Red Hat Enterprise Linux 9 product related. CIS CIS Benchmark related. labels Apr 25, 2023
@marcusburghardt marcusburghardt added this to the 0.1.68 milestone Apr 25, 2023
@marcusburghardt marcusburghardt requested a review from a team as a code owner April 25, 2023 11:45
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Apr 25, 2023

Code Climate has analyzed commit 1ba6a72 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Apr 26, 2023
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879 Mab879 merged commit bc5bd7c into ComplianceAsCode:master Apr 26, 2023
@marcusburghardt marcusburghardt deleted the cis_audit_permissions branch April 26, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. New Rule Issues or pull requests related to new Rules. RHEL9 Red Hat Enterprise Linux 9 product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants