Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop of some rules from SLE 12/15 profiles #10527

Conversation

rumch-se
Copy link
Contributor

@rumch-se rumch-se commented May 5, 2023

Description:

  • _The following rules accounts_passwords_pam_faillock_deny, accounts_passwords_pam_faillock_deny_root, accounts_passwords_pam_faillock_interval, accounts_passwords_pam_faillock_unlock_time are removed from SLE 12/15 profiles _

Rationale:

  • All rules use package/technology which is not supported by SUSE

@rumch-se rumch-se requested a review from a team as a code owner May 5, 2023 08:12
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 5, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented May 5, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt marcusburghardt added SLES SUSE Linux Enterprise Server product related. ANSSI ANSSI Benchmark related. pci-dss labels May 5, 2023
@marcusburghardt marcusburghardt added this to the 0.1.68 milestone May 5, 2023
@marcusburghardt
Copy link
Member

@teacup-on-rockingchair could you take a look at this PR please? If it looks good after completing the CI tests, feel free to merge it.

@rumch-se
Copy link
Contributor Author

Hello @teacup-on-rockingchair
The corrections discussed ware done.
Have a nice day
Rumen

@codeclimate
Copy link

codeclimate bot commented May 10, 2023

Code Climate has analyzed commit 21adb5b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.

@teacup-on-rockingchair teacup-on-rockingchair merged commit 1e0a6c4 into ComplianceAsCode:master May 14, 2023
@jan-cerny jan-cerny added the Update Profile Issues or pull requests related to Profiles updates. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ANSSI ANSSI Benchmark related. needs-ok-to-test Used by openshift-ci bot. pci-dss SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants