Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Action Versions #10543

Merged
merged 8 commits into from
May 26, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented May 9, 2023

Description:

Update actions dependacies

Rationale:

actions/checkout@v2 (and other actions) use a version of node that is unsuported and may not work soon. See
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

@Mab879 Mab879 added the Infrastructure Our content build system label May 9, 2023
@Mab879 Mab879 added this to the 0.1.68 milestone May 9, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label May 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 9, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Mab879 Mab879 changed the title Use actions/checkout@v3 Update GitHub Action Versions May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Mab879 added 4 commits May 9, 2023 15:17
It uses NodeJS 12 which is outdated and will be removed soon.
It is easy to move to use apt-get.
This update does what the action was doing anyways.
@konstruktoid
Copy link
Contributor

I'm probably missing something, but why not enable dependabot or renovate or something similar instead of doing manual updates?

@Mab879
Copy link
Member Author

Mab879 commented May 16, 2023

I'm probably missing something, but why not enable dependabot or renovate or something similar instead of doing manual updates?

That is good idea. Since we are so far behind on the updates I think it might sense for this round to be manual to ensure we are not breaking things. For example, I needed to upgrade the configuration for our changelog action.

@Mab879 Mab879 marked this pull request as ready for review May 23, 2023 20:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label May 23, 2023
@marcusburghardt marcusburghardt self-assigned this May 25, 2023
@marcusburghardt
Copy link
Member

Automatus Fedora / Run Tests (pull_request) doesn't seem to be related but I am not sure on how to properly trigger a complete new/updated job for it and confirm.

@codeclimate
Copy link

codeclimate bot commented May 25, 2023

Code Climate has analyzed commit 81b7326 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.5% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt merged commit 27ed9ad into ComplianceAsCode:master May 26, 2023
@Mab879 Mab879 deleted the update_actions branch May 26, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants