Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in the SLE 12/15 rule sshd_use_strong_kex #10544

Conversation

rumch-se
Copy link
Contributor

@rumch-se rumch-se commented May 9, 2023

Description:

  • _Fixes usage of kex for SLE 12/15 _

Rationale:

  • This fix is necessary because at the moment the rule is using weak keys

@rumch-se rumch-se requested a review from a team as a code owner May 9, 2023 14:41
@openshift-ci
Copy link

openshift-ci bot commented May 9, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt marcusburghardt added this to the 0.1.68 milestone May 10, 2023
@marcusburghardt marcusburghardt added SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates. labels May 10, 2023
@teacup-on-rockingchair
Copy link
Contributor

👍 @rumch-se PR needs rebase, but after that it can be merged

@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label May 15, 2023
@rumch-se rumch-se force-pushed the fix_in_sshd_use_strong_kex branch from 8d33786 to e1573cb Compare May 15, 2023 08:48
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label May 15, 2023
@codeclimate
Copy link

codeclimate bot commented May 16, 2023

Code Climate has analyzed commit 16f13c0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean 👍

@teacup-on-rockingchair teacup-on-rockingchair merged commit 1462023 into ComplianceAsCode:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants