-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix into the rule sysctl_kernel_randomize_va_space #10555
Fix into the rule sysctl_kernel_randomize_va_space #10555
Conversation
Hi @rumch-se. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rumch-se Hi, the change looks good to me.
I just requested one small change as it affects RHEL in an unwated way.
Hello @yuumasato |
Hello @teacup-on-rockingchair, @yuumasato and @jan-cerny Have a nice day |
@rumch-se Sure, it will be possible after you address the problems that @yuumasato mentioned above. |
Hello @jan-cerny |
The CI errors are probably related to the last commit, which was a merge commit. I believe the intention was to rebase the PR instead of merging the master into it. Could you take a look, please? |
cefc015
to
0b616d5
Compare
0b616d5
to
8ceba9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the update of the SLE STIG reference file seems out of place.
8ceba9c
to
ae9eb19
Compare
Code Climate has analyzed commit ae9eb19 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.2% (0.0% change). View more on Code Climate. |
Description:
Rationale:
/etc/sysctl.d/
/usr/local/lib/sysctl.d/
/usr/lib/sysctl.d/
/lib/sysctl.d/
/etc/sysctl.conf