bugfix: packages: delim is comma

[maage]

Description:

Test files # <parameter> = delimiter is ,.

Rationale:

There might be issues when installing packages.

Review Hints:

Changes all over, so expect some breakage when rules is not fit to be tested in some test env.

[openshift-ci]

Hi @maage. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[maage]

These need to have different tag than ERROR. It is not error of this PR.

ERROR - Rule 'xccdf_org.ssgproject.content_rule_grub2_enable_fips_mode' isn't present in benchmark 'xccdf_org.ssgproject.content_benchmark_RHEL-8' in '/tmp/ssgts-ds-oimm9gk2'
ERROR - Rule 'xccdf_org.ssgproject.content_rule_smartcard_auth' isn't present in benchmark 'xccdf_org.ssgproject.content_benchmark_RHEL-8' in '/tmp/ssgts-ds-oimm9gk2'
INFO - xccdf_org.ssgproject.content_rule_service_atd_disabled

[codeclimate]

Code Climate has analyzed commit e48bf7c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4%.

View more on Code Climate.

[jan-cerny]

I have verified that the packages tag is indeed split on commas internally. I have executed a test scenario.

[jcerny@thinkpad scap-security-guide{pr/10559}]$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 --scenario service_disabled_rpcstatd_enabled.pass.sh service_atd_disabled
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2023-05-15-0938/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_service_atd_disabled
INFO - Script service_disabled_rpcstatd_enabled.pass.sh using profile (all) OK

The CI fail is caused by the fact that the rule isn't part of rhel9/rhel8 benchmarks.