-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: packages: delim is comma #10559
Conversation
Hi @maage. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
These need to have different tag than
|
Code Climate has analyzed commit e48bf7c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.4%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have verified that the packages tag is indeed split on commas internally. I have executed a test scenario.
[jcerny@thinkpad scap-security-guide{pr/10559}]$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel9 --scenario service_disabled_rpcstatd_enabled.pass.sh service_atd_disabled
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2023-05-15-0938/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_service_atd_disabled
INFO - Script service_disabled_rpcstatd_enabled.pass.sh using profile (all) OK
The CI fail is caused by the fact that the rule isn't part of rhel9/rhel8 benchmarks.
Description:
Test files
# <parameter> =
delimiter is,
.Rationale:
There might be issues when installing packages.
Review Hints:
Changes all over, so expect some breakage when rules is not fit to be tested in some test env.