-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install-vm fixes / features #10562
install-vm fixes / features #10562
Conversation
At least qemu / libvirt in Fedora 37 seemed to need this. qemu-kvm-7.0.0-15.fc37.x86_64 libvirt-daemon-8.6.0-5.fc37.x86_64
Hi @maage. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Code Climate has analyzed commit ba73850 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.4%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I tested it with standard installation of RHEL 8 (affected by biosboot addition) and it works as expected.
Description:
I have used
install-vm
and some pain points here.Support
biosboot
in newer Fedora.Support option
--disk-unsafe
, there is--disk
where I can put all kinds of entries, but I rather havecache=unsafe
from start and use defaults. Changed howdisk_spec
is handled.Use
argparse.ArgumentDefaultsHelpFormatter
to get nicer help.Allow to run from other directory than 'tests'.
Rationale:
Small contained improvements needed.
Review Hints:
I have also CentOS 7 machine and there is no regression.