Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLE 12/15 profile updates #10577

Conversation

rumch-se
Copy link
Contributor

Description:

  • _These updates covers SLE 12/15 profiles which include rules cracklib_accounts_password_pam_xxxx _

Rationale:

  • Some of current profiles do not include rules and variable definitions used by these rules

@rumch-se rumch-se requested a review from a team as a code owner May 16, 2023 14:10
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Mab879 Mab879 added this to the 0.1.68 milestone May 16, 2023
@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates. STIG STIG Benchmark related. ANSSI ANSSI Benchmark related. pci-dss labels May 16, 2023
Copy link
Contributor

@brett060102 brett060102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

controls/pcidss_4.yml Outdated Show resolved Hide resolved
@rumch-se
Copy link
Contributor Author

Hello @teacup-on-rockingchair
The proposed change was done
Have a nice day
Rumen

@codeclimate
Copy link

codeclimate bot commented May 22, 2023

Code Climate has analyzed commit 05b1bf4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.5% (0.1% change).

View more on Code Climate.

@teacup-on-rockingchair teacup-on-rockingchair merged commit e2401f3 into ComplianceAsCode:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ANSSI ANSSI Benchmark related. needs-ok-to-test Used by openshift-ci bot. pci-dss SLES SUSE Linux Enterprise Server product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants