-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SLE 12/15 rule and change package name #10580
Update SLE 12/15 rule and change package name #10580
Conversation
Hi @rumch-se. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This datastream diff is auto generated by the check Click here to see the full diffNew content has different text for rule 'xccdf_org.ssgproject.content_rule_package_audit-libs_installed'.%0A--- xccdf_org.ssgproject.content_rule_package_audit-libs_installed%0A+++ xccdf_org.ssgproject.content_rule_package_audit-libs_installed%0A@@ -1,9 +1,9 @@%0A %0A [title]:%0A-Ensure the audit-libs package as a part of audit Subsystem is Installed%0A+Ensure the libaudit package as a part of audit Subsystem is Installed%0A %0A [description]:%0A-The audit-libs package should be installed.%0A+The libaudit package should be installed.%0A %0A [reference]:%0A BP28(R50)%0A%0AOCIL for rule 'xccdf_org.ssgproject.content_rule_package_audit-libs_installed' differs.%0A--- ocil:ssg-package_audit-libs_installed_ocil:questionnaire:1%0A+++ ocil:ssg-package_audit-libs_installed_ocil:questionnaire:1%0A@@ -1,3 +1,3 @@%0A-Run the following command to determine if the audit-libs package is installed: $ rpm -q audit-libs%0A- Is it the case that the audit package is not installed?%0A+Run the following command to determine if the libaudit package is installed: $ rpm -q libaudit%0A+ Is it the case that the libaudit package is not installed?%0A |
@@ -1,10 +1,10 @@ | |||
documentation_complete: true | |||
|
|||
title: 'Ensure the audit-libs package as a part of audit Subsystem is Installed' | |||
title: 'Ensure the libaudit package as a part of audit Subsystem is Installed' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not a good idea to rename an existing rule:
https://complianceascode.readthedocs.io/en/latest/manual/developer/06_contributing_with_content.html#agreements
You should create a new rule if a new name is indeed necessary.
Otherwise, I would recommend to keep the existing name and use Jinja2 in the rule description.
But since this rule is restricted to sle
products. It should be fine to simply rename the "package" on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree on this point 👍 if only the package name is changed it would be less disruptive change and later on every platform can decide utilise it with its own package naming
Code Climate has analyzed commit 0a297b8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.5% (0.1% change). View more on Code Climate. |
Hello @teacup-on-rockingchair |
Description:
Rationale: