Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SLE 12/15 rule and change package name #10580

Conversation

rumch-se
Copy link
Contributor

Description:

  • The PR renames rules and package name for SLE 12/15 and updates CIS profiles

Rationale:

  • Instead of libaudit the current version of the rule uses audit-libs

@rumch-se rumch-se requested a review from a team as a code owner May 17, 2023 06:47
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 17, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented May 17, 2023

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_package_audit-libs_installed'.%0A--- xccdf_org.ssgproject.content_rule_package_audit-libs_installed%0A+++ xccdf_org.ssgproject.content_rule_package_audit-libs_installed%0A@@ -1,9 +1,9 @@%0A %0A [title]:%0A-Ensure the audit-libs package as a part of audit Subsystem is Installed%0A+Ensure the libaudit package as a part of audit Subsystem is Installed%0A %0A [description]:%0A-The audit-libs package should be installed.%0A+The libaudit package should be installed.%0A %0A [reference]:%0A BP28(R50)%0A%0AOCIL for rule 'xccdf_org.ssgproject.content_rule_package_audit-libs_installed' differs.%0A--- ocil:ssg-package_audit-libs_installed_ocil:questionnaire:1%0A+++ ocil:ssg-package_audit-libs_installed_ocil:questionnaire:1%0A@@ -1,3 +1,3 @@%0A-Run the following command to determine if the audit-libs package is installed: $ rpm -q audit-libs%0A-      Is it the case that the audit package is not installed?%0A+Run the following command to determine if the libaudit package is installed: $ rpm -q libaudit%0A+      Is it the case that the libaudit package is not installed?%0A       

@marcusburghardt marcusburghardt added the SLES SUSE Linux Enterprise Server product related. label May 17, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

sle12 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@@ -1,10 +1,10 @@
documentation_complete: true

title: 'Ensure the audit-libs package as a part of audit Subsystem is Installed'
title: 'Ensure the libaudit package as a part of audit Subsystem is Installed'
Copy link
Member

@marcusburghardt marcusburghardt May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a good idea to rename an existing rule:
https://complianceascode.readthedocs.io/en/latest/manual/developer/06_contributing_with_content.html#agreements

You should create a new rule if a new name is indeed necessary.
Otherwise, I would recommend to keep the existing name and use Jinja2 in the rule description.
But since this rule is restricted to sle products. It should be fine to simply rename the "package" on it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on this point 👍 if only the package name is changed it would be less disruptive change and later on every platform can decide utilise it with its own package naming

@codeclimate
Copy link

codeclimate bot commented May 26, 2023

Code Climate has analyzed commit 0a297b8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.5% (0.1% change).

View more on Code Climate.

@rumch-se
Copy link
Contributor Author

Hello @teacup-on-rockingchair
I changed the name again and implemented the proposed changes.
All the best
Rumen

@marcusburghardt marcusburghardt added the Update Rule Issues or pull requests related to Rules updates. label May 30, 2023
@marcusburghardt marcusburghardt added this to the 0.1.69 milestone May 30, 2023
@marcusburghardt marcusburghardt changed the title Rename SLE 12/15 rule and change package name Update SLE 12/15 rule and change package name May 30, 2023
@marcusburghardt marcusburghardt merged commit d7ed76d into ComplianceAsCode:master May 30, 2023
@marcusburghardt marcusburghardt self-assigned this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants