Publish rendered policy artifacts #10585
Conversation
The rules attribute doesn't exist so nothing was being rendered.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
ggbecker
force-pushed
the
publish-render-policy-artifacts
branch
2 times, most recently
from
cf94c62
to
ca60604
Compare
|
Here's a proof of concept for the rendered policies we talked about. You can find the artifacts here: When we merge it, this would be shown in this page: https://complianceascode.github.io/content-pages/ |
|
Is it a WIP PR? If so, could you set it as |
It isn't anymore. I'm keeping the ready status and will update the title. |
ggbecker
changed the title
ggbecker
force-pushed
the
publish-render-policy-artifacts
branch
2 times, most recently
from
e2a722e
to
c0e39a6
Compare
|
The new page looks like this:
|
ggbecker
force-pushed
the
publish-render-policy-artifacts
branch
4 times, most recently
from
7855a6d
to
846e4e8
Compare
the items are now sorted |
|
@yuumasato I think this should be good to go. |
utils/gen_rendered_policies_index.py
Outdated
|
|
||
| import ssg.jinja | ||
| from utils.template_renderer import FlexibleLoader | ||
| from utils.gen_html_guides_index import create_index |
There was a problem hiding this comment.
I value the reuse of code, but this function is not in a module/file in which it is explicit that it is reused.
One update to the utils/gen_html_guides_index.py changing that function may break this script.
There was a problem hiding this comment.
I agree, it's the codeclimate bothering our lives... I guess I can just return it back be we can waive the codeclimate results.
They scan all the control files and render the policy according to the product being built.
Store the built content that can be inspected locally to check if the built pages are correct.
There are output files that don't need to be regenerated every time so the custom command should work better here.
Disregard any other folder that might contain product.yml files, for example the build/ directory would have them after the project was built. Creating duplicated guides entries in the rendered guides page.
ggbecker
force-pushed
the
publish-render-policy-artifacts
branch
from
846e4e8
to
cba0ade
Compare
|
@yuumasato feedback addressed |
|
Code Climate has analyzed commit cba0ade and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.5% (0.0% change). View more on Code Climate. |
jan-cerny
added
the
Highlight
Description