Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ssg_test_suite: warning when rule not in benchmark #10642

Merged
merged 1 commit into from
May 30, 2023
Merged

fix: ssg_test_suite: warning when rule not in benchmark #10642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/ssg_test_suite/rule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,10 +309,10 @@ def _get_rules_to_test(self):
if not self._rule_matches_rule_spec(short_rule_id):
continue
if full_rule_id not in all_rules_in_benchmark:
# This is an error only if the user specified the rules to be
# This is a problem only if the user specified the rules to be
# tested explicitly using command line arguments
if self.target_type == "rule ID":
logging.error(
logging.warning(
"Rule '{0}' isn't present in benchmark '{1}' in '{2}'"
.format(
full_rule_id, self.benchmark_id, self.datastream))
Expand Down