Add remediations for rule network_sniffer_disabled #10659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
This datastream diff is auto generated by the check Click here to see the full diffNew datastream adds bash remediation for rule 'xccdf_org.ssgproject.content_rule_network_sniffer_disabled'.%0ANew datastream adds ansible remediation for rule 'xccdf_org.ssgproject.content_rule_network_sniffer_disabled'. |
Mab879
approved these changes
May 31, 2023
Mab879
requested changes
May 31, 2023
There was a problem hiding this comment.
I have proposed a few changed to be in line with the style guide.
linux_os/guide/system/network/network_sniffer_disabled/ansible/shared.yml
Outdated
Show resolved
Hide resolved
linux_os/guide/system/network/network_sniffer_disabled/ansible/shared.yml
Outdated
Show resolved
Hide resolved
linux_os/guide/system/network/network_sniffer_disabled/ansible/shared.yml
Outdated
Show resolved
Hide resolved
linux_os/guide/system/network/network_sniffer_disabled/ansible/shared.yml
Outdated
Show resolved
Hide resolved
linux_os/guide/system/network/network_sniffer_disabled/ansible/shared.yml
Outdated
Show resolved
Hide resolved
|
Automatus failures are expected due the nature of the rule. |
This includes bash and ansible remediations Signed-off-by: Federico Ramirez <federico.r.ramirez@oracle.com>
freddieRv
force-pushed
the
network_sniffer_disabled-remediations
branch
from
e7c7cd0
to
676d8d1
Compare
|
Code Climate has analyzed commit 676d8d1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.8% (0.0% change). View more on Code Climate. |
Mab879
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
network_sniffer_disabledRationale:
Review Hints:
ip link show. I'm open to suggestions on how to improve this remediation.