Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLE Add journald configuration droping remediations #10671

Conversation

teacup-on-rockingchair
Copy link
Contributor

Description:

  • Add SLE specific remedaitions for journald

Rationale:

  • The remediations use dropin configuration files for better system maintenance

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jun 2, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 2, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review June 26, 2023 14:10
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jun 26, 2023
@jan-cerny jan-cerny self-assigned this Jun 30, 2023
@jan-cerny jan-cerny added this to the 0.1.69 milestone Jun 30, 2023
@jan-cerny jan-cerny added Ansible Ansible remediation update. Bash Bash remediation update. labels Jun 30, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teacup-on-rockingchair This looks great. But I noticed that all 3 rules have very similar contents. Have you considered creating a macro or a template to avoid code duplication?

@vojtapolasek vojtapolasek modified the milestones: 0.1.69, 0.1.70 Jul 18, 2023
@jan-cerny
Copy link
Collaborator

@teacup-on-rockingchair ^

@teacup-on-rockingchair
Copy link
Contributor Author

@teacup-on-rockingchair This looks great. But I noticed that all 3 rules have very similar contents. Have you considered creating a macro or a template to avoid code duplication?

Was reluctant to add it as template since I considered it platform dependent approach but will add a template and have the platform dependency in the rule itself 👍

@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as draft July 23, 2023 10:56
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 23, 2023
@openshift-merge-robot openshift-merge-robot added needs-rebase Used by openshift-ci bot. and removed needs-rebase Used by openshift-ci bot. labels Jul 23, 2023
@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review July 26, 2023 12:08
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 26, 2023
@teacup-on-rockingchair teacup-on-rockingchair force-pushed the sle_journald_dropin_remediations branch 2 times, most recently from ea2d36f to b68e255 Compare July 27, 2023 04:08
@jan-cerny
Copy link
Collaborator

/packit retest-failed

@jan-cerny
Copy link
Collaborator

@teacup-on-rockingchair the shellcheck problems that you can see in the "Gate / Build, Test on Fedora Latest (Container) (pull_request) " output look legit, I think the main driver is the extra space in "${ COMPONENT_PARAM_REMEDY_CFG}.bak"

@codeclimate
Copy link

codeclimate bot commented Aug 1, 2023

Code Climate has analyzed commit d4dc9b7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

@teacup-on-rockingchair
Copy link
Contributor Author

@jan-cerny can you please approve this one if you see no other issues with it?

@jan-cerny jan-cerny merged commit d81f29b into ComplianceAsCode:master Aug 2, 2023
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update. Bash Bash remediation update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants