-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLE Add journald configuration droping remediations #10671
SLE Add journald configuration droping remediations #10671
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teacup-on-rockingchair This looks great. But I noticed that all 3 rules have very similar contents. Have you considered creating a macro or a template to avoid code duplication?
Was reluctant to add it as template since I considered it platform dependent approach but will add a template and have the platform dependency in the rule itself 👍 |
ea2d36f
to
b68e255
Compare
b68e255
to
cc01df2
Compare
/packit retest-failed |
@teacup-on-rockingchair the shellcheck problems that you can see in the "Gate / Build, Test on Fedora Latest (Container) (pull_request) " output look legit, I think the main driver is the extra space in |
Thanks to @jan-cerny for the tip
Code Climate has analyzed commit d4dc9b7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.2% (0.0% change). View more on Code Climate. |
@jan-cerny can you please approve this one if you see no other issues with it? |
Description:
Rationale: