Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of package_libreswan_installed from SLE 12/15 profiles #10696

Conversation

rumch-se
Copy link
Contributor

@rumch-se rumch-se commented Jun 7, 2023

Description:

  • _The package package_libreswan_installed was removed from PCI DSS profiles for SLE 12/15 _

Rationale:

  • SLE 12/15 uses strongswan package

@rumch-se rumch-se requested a review from a team as a code owner June 7, 2023 12:51
@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_package_libreswan_installed'.
--- xccdf_org.ssgproject.content_rule_package_libreswan_installed
+++ xccdf_org.ssgproject.content_rule_package_libreswan_installed
@@ -3,7 +3,7 @@
 Install libreswan Package
 
 [description]:
-The Libreswan package provides an implementation of IPsec
+The libreswan package provides an implementation of IPsec
 and IKE, which permits the creation of secure tunnels over
 untrusted networks. The libreswan package can be installed with the following command:
 

@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates. pci-dss labels Jun 9, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Jun 16, 2023
Co-authored-by: Gabriel Becker <ggasparb@redhat.com>
@rumch-se rumch-se force-pushed the fix_in_package_libreswan_installed branch from 14ec62e to 54355d1 Compare June 19, 2023 06:34
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Jun 19, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 19, 2023

Code Climate has analyzed commit 54355d1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.9% (0.0% change).

View more on Code Climate.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @teacup-on-rockingchair can you please approve?

@teacup-on-rockingchair teacup-on-rockingchair merged commit 2f50cab into ComplianceAsCode:master Jun 21, 2023
30 checks passed
@marcusburghardt marcusburghardt added this to the 0.1.69 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. pci-dss SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants