-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no_rsh_trust_files: depend on rsh-server being installed #10809
Conversation
Hi @candrews. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Please take look the build failures and my comment.
linux_os/guide/services/obsolete/r_services/no_rsh_trust_files/rule.yml
Outdated
Show resolved
Hide resolved
f1653ae
to
44b421b
Compare
The CI errors seems legit. The components mapping should be updated. |
@candrews the error in CI tests is this:
It should be simple to fix by including the rule in proper component file. |
@candrews this PR is almost ready to be merged. The pending issue should be simple to be fixed. |
no_rsh_trust_files is only applicable if rsh-server is installed. Signed-off-by: Craig Andrews <candrews@integralblue.com>
44b421b
to
66cc43a
Compare
I've made that change and updated this PR - thank you for this information and the reminder to get this done 👍 |
Code Climate has analyzed commit 66cc43a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.2% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
@Mab879 it is up to you. The packit tests can be waived in this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well!
/packit rebuild-failed |
Description:
no_rsh_trust_files: depend on rsh-server being installed
Rationale:
no_rsh_trust_files is only applicable if rsh-server is installed.