-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using "imp" module #10819
Stop using "imp" module #10819
Conversation
Fixes broken build on Fedora Rawhide. The deprecated importlib API has been removed from Python 3.12, see python/cpython#98040. Addressing: Traceback (most recent call last): File "/builddir/build/BUILD/scap-security-guide-0.1.69/build-scripts/build_templated_content.py", line 9, in <module> import ssg.templates File "/builddir/build/BUILD/scap-security-guide-0.1.69/ssg/templates.py", line 5, in <module> import imp ModuleNotFoundError: No module named 'imp'
Skipping CI for Draft Pull Request. |
Code Climate has analyzed commit 9fd541b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 6.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.4% (-0.1% change). View more on Code Climate. |
This fixed the broken Packit build. But it didn't fix the GH Actions build, where the problem is different. |
It appears that GH Actions job is broken due to numpy/numpy#23808. |
@Mab879 Thanks for the discovery! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built all products and ran ctests for them and they ran as expected.
Fixes broken build on Fedora Rawhide.
The deprecated importlib API has been removed from Python 3.12, see python/cpython#98040.
Addressing: