-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rules for CIS OCP Section 1.4 #10840
Implement rules for CIS OCP Section 1.4 #10840
Conversation
I know the PR is simple but could you provide a description, please? This is useful for less technical audience. |
f75ef3a
to
65e5537
Compare
This datastream diff is auto generated by the check Click here to see the full diffNew content has different text for rule 'xccdf_org.ssgproject.content_rule_rbac_debug_role_protects_pprof'.
--- xccdf_org.ssgproject.content_rule_rbac_debug_role_protects_pprof
+++ xccdf_org.ssgproject.content_rule_rbac_debug_role_protects_pprof
@@ -35,9 +35,6 @@
[reference]:
1.3.1
-[reference]:
-1.4.1
-
[rationale]:
Profiling allows for the identification of specific performance bottlenecks.
It generates a significant amount of program data that could potentially be |
65e5537
to
25f2f8d
Compare
applications/openshift/scheduler/scheduler_profiling_protected_by_rbac/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/scheduler/scheduler_profiling_protected_by_rbac/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/scheduler/scheduler_profiling_protected_by_rbac/rule.yml
Outdated
Show resolved
Hide resolved
25f2f8d
to
3b849ca
Compare
applications/openshift/scheduler/scheduler_profiling_protected_by_rbac/rule.yml
Show resolved
Hide resolved
Now that we have control files for the new OpenShift 1.4.0 profile, let's start filling in the sections with rules that implement it.
3b849ca
to
ea19775
Compare
/test e2e-aws-ocp4-cis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Lance, LGTM.
Code Climate has analyzed commit ea19775 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.2% (0.0% change). View more on Code Climate. |
Rawhide is failing on |
Now that we have control files for the new OpenShift 1.4.0 profile, let's start filling in the sections with rules that implement it.