Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0640 permission in permissions_local_var_log should only apply to files #10856

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

cueball23
Copy link
Contributor

Description:

Ubuntu remediation for permissions_local_var_log changes the permission of /var/log to 0640 as a result services like lighttpd can't access it logfiles.

Rationale:

Services should be able to access their logfiles.

Review Hints:

In the yml file for this rule the check is listet for files only.

sudo find /var/log -perm /137 -type f -exec stat -c "%n %a" {} \;

Thank you.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 17, 2023

Hi @cueball23. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

sle12 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 requested a review from dodys July 17, 2023 18:11
@codeclimate
Copy link

codeclimate bot commented Jul 17, 2023

Code Climate has analyzed commit e918dda and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added Bash Bash remediation update. Ubuntu Ubuntu product related. labels Jul 17, 2023
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for providing this fix.
The test errors are unrelated to this PR.

@dodys dodys merged commit f880ce8 into ComplianceAsCode:master Jul 18, 2023
27 of 30 checks passed
@Mab879 Mab879 added this to the 0.1.70 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants