-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include new kickstart files for CCN profiles #10863
Include new kickstart files for CCN profiles #10863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @marcusburghardt and thank you for the addition. I found just two small things in comments... no big deal but it could cause some confusion for users.
Updated profile level in comments of respective kickstart files Co-authored-by: vojtapolasek <krecoun@gmail.com>
Suggestions committed. |
Code Climate has analyzed commit 0e4ebd7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.3% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thank you.
Description:
Include three new rhel9 kickstart files for CCN profiles.
Rationale:
Easier to test CCN profiles.
Review Hints:
They were based on CIS kickstart files. I only updated the profile name at the end of the file and some comment lines.