Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tickets key to control validation #10872

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jul 18, 2023

Description:

Add the ability to use tickets key in control files.

Rationale:

Fixes #10868

@Mab879 Mab879 added the Infrastructure Our content build system label Jul 18, 2023
@Mab879 Mab879 added this to the 0.1.70 milestone Jul 18, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM.
But I have one question.

ssg/controls.py Outdated Show resolved Hide resolved
@Mab879 Mab879 force-pushed the tickets_please branch 5 times, most recently from 1bbd798 to b61b72b Compare July 20, 2023 22:10
@codeclimate
Copy link

codeclimate bot commented Jul 20, 2023

Code Climate has analyzed commit f2817f6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 requested a review from yuumasato July 21, 2023 14:59
@yuumasato yuumasato merged commit 772e55c into ComplianceAsCode:master Jul 25, 2023
29 of 30 checks passed
@Mab879 Mab879 deleted the tickets_please branch July 25, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control feature for tickets appears broken
2 participants