-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include RHEL indentifiers in logrotate related rules #10904
Merged
Mab879
merged 5 commits into
ComplianceAsCode:master
from
marcusburghardt:logrotate_cce
Jul 28, 2023
Merged
Include RHEL indentifiers in logrotate related rules #10904
Mab879
merged 5 commits into
ComplianceAsCode:master
from
marcusburghardt:logrotate_cce
Jul 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit 171287f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.2% (0.0% change). View more on Code Climate. |
Mab879
approved these changes
Jul 26, 2023
/packit rebuild-failed |
/packit retest-failed |
2 similar comments
/packit retest-failed |
/packit retest-failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CIS
CIS Benchmark related.
RHEL
Red Hat Enterprise Linux product related.
Update Profile
Issues or pull requests related to Profiles updates.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There is a CIS requirement for RHEL regarding logrotate configuration.
It is a manual requirement and therefore the rules are not included in the profile.
However, the were mentioned in
related_rules
and identifiers were included to make them easier to be user in tailoring files.Rationale:
Better CIS control files for RHEL
This PR will unblock the #10796