-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version to profile element in the data stream #10909
Add version to profile element in the data stream #10909
Conversation
/packit retest-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
We need a test for this feature.
It would be nice to fix the code complexity although it's been very complex before.
a9d17a2
to
4f55423
Compare
Code Climate has analyzed commit 4f55423 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.2% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have built the data stream and I have viewed the version elements and their contents.
Thanks for this change!
Description:
Adds version numbers for profiles to the data stream based on the metadata version information.
Rationale:
To aid in future features.
Review Hints:
./build_product -j10 rhel8
grep xccdf-1.2:version build/ssg-*-ds.xml