Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create runtime_kernel_fips_enabled cpe and apply it to service_rngd_enabled for OL8 #10916

Merged

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Jul 27, 2023

Description:

  • Introduce the cpe runtime_kernel_fips_enabled
  • Update platform in service_rngd_enabled rule to restrict the usage depending on OL version and runtime_kernel_fips_enabled cpe

Rationale:

  • With new OL8 STIG V1R7 it was updated the applicability of the requirement implemented by service_rngd_enabled:

Note: For OL versions 8.4 and above running with kernel FIPS mode enabled as specified by OL08-00-010020, this requirement is not applicable.

  • It is known that the kernel parameter is not enough to declare a system in FIPS mode, however in this case as rngd is related to kernel entropy, this should be enough to validate applicability.

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2023

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Jul 27, 2023

Code Climate has analyzed commit 4b2261b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

@mildas
Copy link
Contributor

mildas commented Jul 28, 2023

/packit retest-failed

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built the OL 8 content and reviewed the rule's platform and related OVAL checks.

@jan-cerny jan-cerny added the Oracle Linux Oracle Linux product related. label Aug 2, 2023
@jan-cerny jan-cerny added this to the 0.1.70 milestone Aug 2, 2023
@jan-cerny jan-cerny merged commit be257e1 into ComplianceAsCode:master Aug 2, 2023
29 of 30 checks passed
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. Oracle Linux Oracle Linux product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants