Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule logind_session_timeout to OL8 STIG #10917

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Add rule logind_session_timeout to OL8 STIG #10917

merged 1 commit into from
Jul 31, 2023

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Jul 27, 2023

Description:

  • Add ol8 prodtype and STIG ID to the rule logind_session_timeout, and add the rule to the STIG profile

Rationale:

  • Keep OL8 STIG profile up to date with DISA's STIG V1R7

@Xeicker
Add rule logind_session_timeout to OL8 STIG
ce00228 
Add ol8 prodtype and STIG ID to the rule, and add the rule to the STIG
profile

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker Xeicker requested a review from a team as a code owner July 27, 2023 22:46
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2023

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Jul 27, 2023

Code Climate has analyzed commit ce00228 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

@mildas
Copy link
Contributor

mildas commented Jul 28, 2023

/packit retest-failed

1 similar comment
@mildas
Copy link
Contributor

mildas commented Jul 28, 2023

/packit retest-failed

jan-cerny
jan-cerny approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI fail on Fedora Rawhide is caused by numpy and isn't caused by the contents of this PR.

@jan-cerny jan-cerny merged commit 129fa26 into ComplianceAsCode:master Jul 31, 2023
29 of 30 checks passed
@Mab879 Mab879 added this to the 0.1.70 milestone Sep 14, 2023
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

@freddieRv freddieRv freddieRv approved these changes

Assignees

@jan-cerny jan-cerny

Labels
needs-ok-to-test Used by openshift-ci bot. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.70
Development

Successfully merging this pull request may close these issues.
5 participants
@Xeicker @mildas @jan-cerny @freddieRv @Mab879