Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable package_cryptsetup-luks_installed rule for RHEL9 #10948

Conversation

marcusburghardt
Copy link
Member

Description:

Enable package_cryptsetup-luks_installed rule for rhel9.

Rationale:

Better CCN coverage for RHEL9.

@marcusburghardt marcusburghardt added RHEL9 Red Hat Enterprise Linux 9 product related. CCN CCN Benchmark related. labels Aug 3, 2023
@marcusburghardt marcusburghardt added this to the 0.1.70 milestone Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Start a new ephemeral environment with changes proposed in this pull request:

rhel7 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed'.
--- xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed
+++ xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed
@@ -1,11 +1,11 @@
 
 [title]:
-Install cryptsetup-luks Package
+Install cryptsetup Package
 
 [description]:
-The cryptsetup-luks package can be installed with the following command:
+The cryptsetup package can be installed with the following command:
 
-$ sudo yum install cryptsetup-luks
+$ sudo yum install cryptsetup
 
 [rationale]:
 LUKS is the upcoming standard for Linux hard disk encryption. By providing a standard
@@ -13,9 +13,7 @@
 provide secure management of multiple user passwords. In contrast to existing solution,
 LUKS stores all necessary setup information in the partition header, enabling the user
 to transport or migrate their data seamlessly. LUKS for dm-crypt is implemented in
-cryptsetup. cryptsetup-luks is intended as a complete replacement for the
-original cryptsetup. It provides all the functionality of the original
-version plus all LUKS features, that are accessible by luks* action.
+cryptsetup.
 
 [ident]:
 CCE-82996-0

OVAL for rule 'xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed' differs.
--- oval:ssg-package_cryptsetup-luks_installed:def:1
+++ oval:ssg-package_cryptsetup-luks_installed:def:1
@@ -1,2 +1,2 @@
 criteria None
-criterion oval:ssg-test_package_cryptsetup-luks_installed:tst:1
+criterion oval:ssg-test_package_cryptsetup_installed:tst:1

OCIL for rule 'xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed' differs.
--- ocil:ssg-package_cryptsetup-luks_installed_ocil:questionnaire:1
+++ ocil:ssg-package_cryptsetup-luks_installed_ocil:questionnaire:1
@@ -1,3 +1,3 @@
-Run the following command to determine if the cryptsetup-luks package is installed: $ rpm -q cryptsetup-luks
+Run the following command to determine if the cryptsetup package is installed: $ rpm -q cryptsetup
       Is it the case that the package is not installed?
       
bash remediation for rule 'xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed' differs.
--- xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed
+++ xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed
@@ -1,4 +1,4 @@
 
-if ! rpm -q --quiet "cryptsetup-luks" ; then
-    yum install -y "cryptsetup-luks"
+if ! rpm -q --quiet "cryptsetup" ; then
+    yum install -y "cryptsetup"
 fi

ansible remediation for rule 'xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed' differs.
--- xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed
+++ xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed
@@ -1,6 +1,6 @@
-- name: Ensure cryptsetup-luks is installed
+- name: Ensure cryptsetup is installed
   package:
-    name: cryptsetup-luks
+    name: cryptsetup
     state: present
   tags:
   - CCE-82996-0

blueprint remediation for rule 'xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed' differs.
--- xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed
+++ xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed
@@ -1,4 +1,4 @@
 
 [[packages]]
-name = "cryptsetup-luks"
+name = "cryptsetup"
 version = "*"

puppet remediation for rule 'xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed' differs.
--- xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed
+++ xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed
@@ -1,7 +1,7 @@
-include install_cryptsetup-luks
+include install_cryptsetup
 
-class install_cryptsetup-luks {
-  package { 'cryptsetup-luks':
+class install_cryptsetup {
+  package { 'cryptsetup':
     ensure => 'installed',
   }
 }

anaconda remediation for rule 'xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed' differs.
--- xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed
+++ xccdf_org.ssgproject.content_rule_package_cryptsetup-luks_installed
@@ -1,2 +1,2 @@
 
-package --add=cryptsetup-luks
+package --add=cryptsetup

@codeclimate
Copy link

codeclimate bot commented Aug 3, 2023

Code Climate has analyzed commit 897b4b9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.2% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Aug 3, 2023
@Mab879
Copy link
Member

Mab879 commented Aug 3, 2023

The automatus failure on RHEL8 is expected as its excluded by protype.

@Mab879 Mab879 merged commit b762472 into ComplianceAsCode:master Aug 3, 2023
32 of 34 checks passed
@marcusburghardt marcusburghardt deleted the package_cryptsetup-luks_installed_rhel9 branch August 4, 2023 05:41
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCN CCN Benchmark related. RHEL9 Red Hat Enterprise Linux 9 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants