Remove kernel cmdline check #10961
Merged
Remove kernel cmdline check #10961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OVAL in rule enable_fips_mode contains multiple checks. One of these checks tests presence of `fips=1` in `/etc/kernel/cmdline`. Although this is useful for latest RHEL versions, this file doesn't exist on RHEL 8.6 and 9.0. This causes that the rule fails after remediation on these RHEL versions. We want the same OVAL behavior on all minor RHEL releases, therefore we will remove this test from the OVAL completely. Related to: ComplianceAsCode#10897
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
This datastream diff is auto generated by the check Click here to see the full diffOVAL for rule 'xccdf_org.ssgproject.content_rule_enable_fips_mode' differs.
--- oval:ssg-enable_fips_mode:def:1
+++ oval:ssg-enable_fips_mode:def:1
@@ -4,7 +4,6 @@
extend_definition oval:ssg-enable_dracut_fips_module:def:1
extend_definition oval:ssg-configure_crypto_policy:def:1
criterion oval:ssg-test_system_crypto_policy_value:tst:1
-criterion oval:ssg-test_fips_1_argument_in_etc_kernel_cmdline:tst:1
criteria OR
criteria AND
extend_definition oval:ssg-system_info_architecture_s390_64:def:1 |
|
Code Climate has analyzed commit 75dd0e7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.3% (0.0% change). View more on Code Climate. |
ggbecker
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OVAL in rule enable_fips_mode contains multiple checks. One of these checks tests presence of
fips=1in/etc/kernel/cmdline. Although this is useful for latest RHEL versions, this file doesn't exist on RHEL 8.6 and 9.0. This causes that the rule fails after remediation on these RHEL versions.We want the same OVAL behavior on all minor RHEL releases, therefore we will remove this test from the OVAL completely.
Related to: #10897