Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bash_sshd_remediation macro on OL exclusive code #10980

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Fix bash_sshd_remediation macro on OL exclusive code #10980

merged 2 commits into from
Aug 14, 2023

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Aug 10, 2023

Description:

  • Update regex to identify new edge cases on how included files can be

Rationale:

  • With this update it is the identification of included files in sshd_config is more reliable

Review Hints:

  • The added test represents the new edge cases covered

@Xeicker
Fix regex in bash_sshd_remediation macro
c184292 
There where some edge cases for included files not covered by this
regex

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker
Add test to sshd_lineinfile template
92608d4 
This test ensures the remediation handles different ways in which
included files can be written in sshd_config

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2023

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Aug 10, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 10, 2023

Code Climate has analyzed commit 92608d4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added the Bash Bash remediation update. label Aug 10, 2023
jan-cerny
jan-cerny approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI fail on Rawhide is caused by missing dnf and CI fail on CS8 is caused by #10978 and these fails aren't related to the contents of this PR.

@jan-cerny jan-cerny self-assigned this Aug 14, 2023
@jan-cerny jan-cerny added this to the 0.1.70 milestone Aug 14, 2023
@jan-cerny jan-cerny merged commit e738815 into ComplianceAsCode:master Aug 14, 2023
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Milestone
0.1.70
Development

Successfully merging this pull request may close these issues.
3 participants
@Xeicker @jan-cerny @Mab879