Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove controller_rotate_kubelet_server_certs from OCP CIS v.1.4.0 #10992

Merged

Conversation

yuumasato
Copy link
Member

Description:

  • Remove controller_rotate_kubelet_server_certs from OCP CIS v.1.4.0

Rationale:

  • The rule was supporting CIS v1.3.0 1.3.6 but it was removed in v1.4.0 update.
    The rule was transferred to CIS v1.4.0 4.2.11 but it is not relevant to this item.

Review Hints:

  • Check CIS v1.4.0, and compare with v1.3.0.

The rule was supporting item 1.3.6 from CIS v1.3.0, but it was removed
from v1.4.0.
@yuumasato yuumasato added OpenShift OpenShift product related. CIS CIS Benchmark related. labels Aug 14, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Aug 14, 2023

Code Climate has analyzed commit 2449a9d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rhmdnd rhmdnd merged commit 8b175c3 into ComplianceAsCode:master Aug 14, 2023
32 of 34 checks passed
@yuumasato yuumasato deleted the remove_rule_from_removed_section branch August 15, 2023 09:14
@yuumasato yuumasato added this to the 0.1.70 milestone Aug 15, 2023
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. OpenShift OpenShift product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants