Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHEL as platform in su pam wheel group remidiation #10995

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

Mackemania
Copy link
Contributor

Description:

-This is to complete a previously merged PR which added use_pam_wheel_group_for_su and ensure_pam_wheel_group_empty to the CIS profile for RHEL 8 and RHEL 9, but didn't add RHEL to platform in the remidiations

Review Hints:

This is to complete a previously merged PR which added
use_pam_wheel_group_for_su and ensure_pam_wheel_group_empty
to the CIS profile for RHEL 8 and RHEL 9, but didn't add RHEL to
platform in the remidiations
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Aug 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

Hi @Mackemania. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Aug 15, 2023

Code Climate has analyzed commit 412fa16 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Aug 15, 2023
@marcusburghardt marcusburghardt added RHEL Red Hat Enterprise Linux product related. CIS CIS Benchmark related. labels Aug 15, 2023
@marcusburghardt marcusburghardt added this to the 0.1.70 milestone Aug 15, 2023
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@marcusburghardt marcusburghardt merged commit ace9060 into ComplianceAsCode:master Aug 15, 2023
30 of 32 checks passed
@Mab879 Mab879 added the Bash Bash remediation update. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update. CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. RHEL Red Hat Enterprise Linux product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants