Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of fixes in PAM related rules for SLE platforms #11014

Conversation

teacup-on-rockingchair
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair commented Aug 23, 2023

Description:

  • Fix accounts_passwords_pam_tally2_unlock_time OVAL check
  • Drop template section for set_password_hashing_algorithm_systemauth rule in sle context

Rationale:

  • The accounts_passwords_pam_tally2_unlock_time check was returning error after ansible remediation due to comparing string with integer and some extra grouping in the regex pattern
  • Now there are custom ansible/bash remediations for set_password_hashing_algorithm_systemauth, that cover sle platforms so the duplication causes only troubles

The check was returning error after ansible remediation due to comparing string with integer and some extra grouping in the regex pattern
@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Aug 23, 2023
@github-actions
Copy link

github-actions bot commented Aug 23, 2023

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Now there are custom ansible/bash remediations that cover sle platforms so the duplication causes only troubles
@teacup-on-rockingchair teacup-on-rockingchair added OVAL OVAL update. Related to the systems assessments. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates. labels Aug 23, 2023
@teacup-on-rockingchair teacup-on-rockingchair changed the title Fix accounts_passwords_pam_tally2_unlock_time OVAL check Couple of fixes in PAM related rules for SLE platforms Aug 23, 2023
@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review August 23, 2023 06:52
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Aug 23, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 23, 2023

Code Climate has analyzed commit 4cab2ed and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.3% (0.0% change).

View more on Code Climate.

@ggbecker
Copy link
Member

/packit retest-failed

@marcusburghardt marcusburghardt self-assigned this Aug 24, 2023
@marcusburghardt marcusburghardt merged commit 0085a63 into ComplianceAsCode:master Aug 24, 2023
36 of 38 checks passed
@Mab879 Mab879 added this to the 0.1.70 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OVAL OVAL update. Related to the systems assessments. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants