Use up to date build_ds_container script in add_platform_rule.py
#11042
Conversation
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
utils/add_platform_rule.py
Outdated
| @@ -277,7 +277,7 @@ def clusterTestFunc(args): | |||
| print('* Pushing image build to cluster') | |||
| # execute the build_ds_container script | |||
| buildp = subprocess.run( | |||
| ['utils/build_ds_container.sh', '-P', 'ocp4', '-P', 'rhcos4']) | |||
| ['utils/build_ds_container.py']) | |||
There was a problem hiding this comment.
I think the python version still supports passing in different products. Should we maintain that?
There was a problem hiding this comment.
Yeah, I think we should keep support for different products in build_ds_container.py.
Switch to the python script. And fix the product arguments, passing '-P' twice was causing it to be reset.
yuumasato
force-pushed
the
fix_add_platform_rule
branch
from
c40d002
to
8a95232
Compare
| @@ -277,7 +277,7 @@ def clusterTestFunc(args): | |||
| print('* Pushing image build to cluster') | |||
| # execute the build_ds_container script | |||
| buildp = subprocess.run( | |||
| ['utils/build_ds_container.sh', '-P', 'ocp4', '-P', 'rhcos4']) | |||
| ['utils/build_ds_container.py', '-P', 'ocp4', 'rhcos4']) | |||
There was a problem hiding this comment.
I added back explicit specification of the products to build.
But I wonder if we should just build whatever is default in build_ds_container.py.
There was a problem hiding this comment.
I believe this script is OpenShift-specific. I'm OK only building ocp4 and rhcos4 products for now.
|
Code Climate has analyzed commit 8a95232 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.8% (0.0% change). View more on Code Climate. |
Description:
Having the '-P' twice caused the script to build only one of the products, the one defined later.
Rationale:
utils/build_ds_container.shis deprecated.