-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UBTU-20-010463 to ensure system does not allow accounts configure… #11061
Add UBTU-20-010463 to ensure system does not allow accounts configure… #11061
Conversation
Hi @dexterle. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
...em/accounts/accounts-restrictions/password_storage/no_empty_passwords/ansible/ubuntu2004.yml
Outdated
Show resolved
Hide resolved
...de/system/accounts/accounts-restrictions/password_storage/no_empty_passwords/oval/shared.xml
Outdated
Show resolved
Hide resolved
..._os/guide/system/accounts/accounts-restrictions/password_storage/no_empty_passwords/rule.yml
Outdated
Show resolved
Hide resolved
..._os/guide/system/accounts/accounts-restrictions/password_storage/no_empty_passwords/rule.yml
Outdated
Show resolved
Hide resolved
..._os/guide/system/accounts/accounts-restrictions/password_storage/no_empty_passwords/rule.yml
Outdated
Show resolved
Hide resolved
..._os/guide/system/accounts/accounts-restrictions/password_storage/no_empty_passwords/rule.yml
Outdated
Show resolved
Hide resolved
..._os/guide/system/accounts/accounts-restrictions/password_storage/no_empty_passwords/rule.yml
Outdated
Show resolved
Hide resolved
...em/accounts/accounts-restrictions/password_storage/no_empty_passwords/ansible/ubuntu2004.yml
Outdated
Show resolved
Hide resolved
cdbfdb0
to
dfbd83e
Compare
Ensured that the Ansible, and Bash remediation are added in for ubuntu support. Fixed rule based on feedback received. |
dfbd83e
to
4846b64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please, only resolve the conflict and it should be ready to be merged.
…d with blank or null pass This commit will implement changes to "no_empty_passwords" rule to feature ubuntu2004 to disable logons with empty passwords. Conflicts: products/ubuntu2004/profiles/stig.profile
4846b64
to
c0499cb
Compare
Awesome! Thanks for the help. |
Code Climate has analyzed commit c0499cb and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.8% (0.0% change). View more on Code Climate. |
Description:
Rationale:
Review Hints:
Build the product:
To test these changes with Ansible:
To test changes with bash, run the remediation section:
xccdf_org.ssgproject.content_rule_no_empty_passwords
Checkout Manual STIG OVAL definitions, and use software like DISA STIG Viewer to view definitions.
This STIG can be tested with the latest Ubuntu 2004 Benchmark SCAP. For reference, please review the latest artifacts: https://public.cyber.mil/stigs/downloads/