Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UBTU-20-010401 to restrict kernel message buffer #11063

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

dexterle
Copy link
Contributor

@dexterle dexterle commented Sep 7, 2023

Description:

  • Add UBTU-20-010401

Rationale:

Review Hints:

Build the product:

./build_product ubuntu2004

To test these changes with Ansible:

ansible-playbook build/ansible/ubuntu2004-playbook-stig.yml --tags "DISA-STIG-UBTU-20-010401"

To test changes with bash, run the remediation section: xccdf_org.ssgproject.content_rule_sysctl_kernel_dmesg_restrict

Checkout Manual STIG OVAL definitions, and use software like DISA STIG Viewer to view definitions.

git checkout dexterle:add-manual-stig-ubtu-20-v1r9

This STIG can not be tested with the latest Ubuntu 2004 Benchmark SCAP. Please perform a manual test by following the check text on the Manual STIG. For reference, please review the latest artifacts: https://public.cyber.mil/stigs/downloads/

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Sep 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 7, 2023

Hi @dexterle. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Sep 7, 2023

Code Climate has analyzed commit 88c83d7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added Ubuntu Ubuntu product related. STIG STIG Benchmark related. labels Sep 8, 2023
@dexterle dexterle marked this pull request as ready for review September 11, 2023 12:59
@dexterle dexterle requested a review from a team as a code owner September 11, 2023 12:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Sep 11, 2023
@dodys
Copy link
Contributor

dodys commented Sep 11, 2023

/packit retest-failed

@dodys dodys added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Sep 11, 2023
@dodys dodys self-assigned this Sep 12, 2023
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@dodys dodys merged commit 7702d30 into ComplianceAsCode:master Sep 12, 2023
37 of 38 checks passed
@Mab879 Mab879 added this to the 0.1.70 milestone Sep 12, 2023
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants