-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UBTU-20-010179 to use proper parameters and key #11080
Fix UBTU-20-010179 to use proper parameters and key #11080
Conversation
Hi @dexterle. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
...rules/audit_kernel_module_loading/audit_rules_kernel_module_loading_finit/ansible/shared.yml
Show resolved
Hide resolved
..._rules/audit_kernel_module_loading/audit_rules_kernel_module_loading_init/ansible/shared.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check your own comments, there are still things to add
This commit will fix the init_module and finit_module for UBTU-20-010179 which will apply proper parameters and keys.
4a5607e
to
92e7882
Compare
added multi_platform_ubuntu given the original PR feedback |
Code Climate has analyzed commit 92e7882 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.8% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Description:
kernel_module_loading_finit
&kernel_module_loading_init
)kernel_module_loading_finit
&kernel_module_loading_init
)kernel_module_loading_finit
&kernel_module_loading_init
)Rationale:
Review Hints:
Build the product:
To test these changes with Ansible:
To test changes with bash, run the remediation section:
xccdf_org.ssgproject.content_rule_audit_rules_kernel_module_loading_finit
andxccdf_org.ssgproject.content_rule_audit_rules_kernel_module_loading_init
Checkout Manual STIG OVAL definitions, and use software like DISA STIG Viewer to view definitions.
This STIG can be tested with the latest Ubuntu 2004 Benchmark SCAP. For reference, please review the latest artifacts: https://public.cyber.mil/stigs/downloads/