Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the rule accounts_passwords_pam_faillock_interval from SLE pro… #11115

Conversation

rumch-se
Copy link
Contributor

…files

Description:

  • Removal of the rule accounts_passwords_pam_faillock_interval from SLE's profiles

Rationale:

  • In SLE OS this setting does not exist and this recommendation is not relevant.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Sep 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Sep 14, 2023

Code Climate has analyzed commit 1f2cc57 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.8% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added the SLES SUSE Linux Enterprise Server product related. label Sep 14, 2023
@marcusburghardt marcusburghardt added this to the 0.1.70 milestone Sep 14, 2023
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Sep 14, 2023
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@teacup-on-rockingchair teacup-on-rockingchair merged commit fba00fb into ComplianceAsCode:master Sep 15, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants