Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sshd lineinfile #11151

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Update sshd lineinfile #11151

merged 2 commits into from
Oct 3, 2023

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Sep 28, 2023

Description:

  • Update regex in ansible to align it with bash so it allows blank spaces leading the Include keyword
  • Update test correct_value_multiple_includes.pass so it validate OVAL is case insensitive and also allows leading spaces

Rationale:

  • Existing ansible code was failing test to remediate from wrong_value_different_includings.fail test

Review Hints:

  • Automatus results should be sufficient
  • This only actually affects OL8 & OL9

@Xeicker
Update ansible in sshd_lineinfile
3fef061 
Update a regex in specifically ansible_sshd_set macro to take into
account leading blank spaces before the Include keyword in sshd_config
file

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker
Update test on sshd_lineinfile
1c35d98 
Update test correct_value_multiple_includes to validate OVAL check is
case insensitive and allow spaces

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Sep 28, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2023

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Sep 28, 2023

Code Climate has analyzed commit 1c35d98 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 56.9%.

View more on Code Climate.

@Mab879 Mab879 added the Bash Bash remediation update. label Sep 28, 2023
@jan-cerny jan-cerny added this to the 0.1.71 milestone Oct 2, 2023
@jan-cerny jan-cerny self-assigned this Oct 2, 2023
jan-cerny
jan-cerny approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changes and executed the test scenarios for the rule sshd_disable_kerb_auth which uses the sshd_lineinfile template whcih is modified here.

@jan-cerny jan-cerny merged commit b9b24d4 into ComplianceAsCode:master Oct 3, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Milestone
0.1.71
Development

Successfully merging this pull request may close these issues.
3 participants
@Xeicker @jan-cerny @Mab879