Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select the var_accounts_passwords_pam_faillock_dir=run in RHEL7 profiles #11163

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Select the var_accounts_passwords_pam_faillock_dir=run in RHEL7 profiles #11163

merged 1 commit into from
Oct 2, 2023

Conversation

ggbecker
Copy link
Member

@ggbecker ggbecker commented Oct 2, 2023

Description:

Rationale:

@ggbecker
Select the var_accounts_passwords_pam_faillock_dir=run in RHEL7 profi…
639d093 
…les.

Rules as audit_rules_login_events_faillock were changed the behavior
in ComplianceAsCode#11007 and didn't have the content updated for RHEL7 according to the
previous default value of
https://github.com/ComplianceAsCode/content/blob/d044199f1b037e632197893adbe3ab2b78ee1138/ssg/constants.py#L475.
@ggbecker ggbecker added OVAL OVAL update. Related to the systems assessments. STIG STIG Benchmark related. labels Oct 2, 2023
@ggbecker ggbecker requested a review from a team as a code owner October 2, 2023 11:25
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Oct 2, 2023

Code Climate has analyzed commit 639d093 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 56.9%.

View more on Code Climate.

@Mab879 Mab879 self-assigned this Oct 2, 2023
@Mab879 Mab879 added this to the 0.1.70 milestone Oct 2, 2023
Mab879
Mab879 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Mab879 Mab879 merged commit afdd1e1 into ComplianceAsCode:master Oct 2, 2023
38 checks passed
@Mab879 Mab879 added the Update Profile Issues or pull requests related to Profiles updates. label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
OVAL OVAL update. Related to the systems assessments. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.70
Development

Successfully merging this pull request may close these issues.

Rules failing as misaligned with DISA
2 participants
@ggbecker @Mab879