Fix SLE15 tests

[svet-se]

Description:

• Override the crontabs package for sle15, and install the python-rpm in the test suite for sle15 Dockerfile

Rationale:

• Add some fixes so the Bash and Ansible tests can be executed without errors

[openshift-ci]

Hi @svet-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment

Oracle Linux 8 Environment

[jan-cerny]

@svet-se What is the reason of these whitespace-only changes?

[svet-se]

@jan-cerny it was generated by running "python ./tests/test_product_stability.py --update-reference-data ./products ./tests/data/product_stability" to update the test data

[ggbecker]

Sounds like we either have to update the tool to generate files that do not disrupt existing files in terms of indentation or only the meaningful changes are kept in this PR (removing all unnecessary white spaces).

[svet-se]

It looks to me like a fix for test_product_stability.py, but for some reason, the files with the new indentation are not regenerated. IMHO this indentation should be OK. @ggbecker please tell me your thoughts about this. There is also an option to add a parameter for a particular product, i.e. to regenerate the test files only for SLE in this case, not for all products in the directory (but in the particular case we caught 2 products without test files).

[teacup-on-rockingchair]

I can confirm that when I run on my setup python ./tests/test_product_stability.py --update-reference-data ./products ./tests/data/product_stability I don't get the changes in the indentation so seems like the yaml generator , used in the test_product_stability tool has some environment dependency

[svet-se]

I've reverted the latest commit and just updated the sle15 test data

[svet-se]

@teacup-on-rockingchair it seems that the issue is related to the Python version, I could confirm that with 3.11 there is no issue and the format is correct.

[codeclimate]

Code Climate has analyzed commit b2c2bc6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 57.0%.

View more on Code Climate.

[teacup-on-rockingchair]

👍