-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SLE15 tests #11172
Fix SLE15 tests #11172
Conversation
Hi @svet-se. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- alinux2: | ||
check_id: installed_OS_is_alinux2 | ||
name: cpe:/o:alinux:alibaba_cloud_linux:2 | ||
title: Alibaba Cloud Linux 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svet-se What is the reason of these whitespace-only changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jan-cerny it was generated by running "python ./tests/test_product_stability.py --update-reference-data ./products ./tests/data/product_stability" to update the test data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like we either have to update the tool to generate files that do not disrupt existing files in terms of indentation or only the meaningful changes are kept in this PR (removing all unnecessary white spaces).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me like a fix for test_product_stability.py, but for some reason, the files with the new indentation are not regenerated. IMHO this indentation should be OK. @ggbecker please tell me your thoughts about this. There is also an option to add a parameter for a particular product, i.e. to regenerate the test files only for SLE in this case, not for all products in the directory (but in the particular case we caught 2 products without test files).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that when I run on my setup python ./tests/test_product_stability.py --update-reference-data ./products ./tests/data/product_stability
I don't get the changes in the indentation so seems like the yaml generator , used in the test_product_stability tool has some environment dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted the latest commit and just updated the sle15 test data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teacup-on-rockingchair it seems that the issue is related to the Python version, I could confirm that with 3.11 there is no issue and the format is correct.
9bca4a1
to
b2c2bc6
Compare
Code Climate has analyzed commit b2c2bc6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 57.0%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
711add0
into
ComplianceAsCode:master
Description:
Rationale: