Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some unnecessary imports #11175

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

isimluk
Copy link
Member

@isimluk isimluk commented Oct 4, 2023

Trying to remove some code and see if this guy still gates.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@isimluk
Copy link
Member Author

isimluk commented Oct 4, 2023

How come I can fail the code climate when I remove the code? I heard that lower footprint improves the climate.

@codeclimate
Copy link

codeclimate bot commented Oct 4, 2023

Code Climate has analyzed commit b090055 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 56.8%.

View more on Code Climate.

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahoj!

I think that the Code Climate bot checks the broader context than only changed lines, so it sometimes finds issues that been there before. I think we can't do much about the code duplication in this case, so I think that it's OK to waive them.

The fail of TF CS9 is tracked in #11179 and isn't caused by the changes in this PR.

Thanks for your patch!

@jan-cerny jan-cerny self-assigned this Oct 5, 2023
@jan-cerny jan-cerny added this to the 0.1.71 milestone Oct 5, 2023
@jan-cerny jan-cerny added the enhancement General enhancements to the project. label Oct 5, 2023
@jan-cerny
Copy link
Collaborator

/packit retest-failed

@jan-cerny jan-cerny merged commit 916401d into ComplianceAsCode:master Oct 5, 2023
37 of 38 checks passed
@Mab879 Mab879 added Documentation Update in project documentation. Infrastructure Our content build system and removed Documentation Update in project documentation. labels Oct 5, 2023
@isimluk isimluk deleted the remove-unneeded-imports branch October 5, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancements to the project. Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants