-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make package installation for iptables and nftables mutually exclusive #11191
Make package installation for iptables and nftables mutually exclusive #11191
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are valid cases where both packages are installed without problems. The problem is when conflicting services are enabled and this was already treated in the #10812. So I don't think we should create a mutually exclusive condition for iptables
and nftables
packages. Maybe these rules could be filtered out in the profile level.
@teacup-on-rockingchair , do you have plans for this PR? |
I believe that using the same approach as in #10812, where the applicability was treated in service level instead of package level, should make this PR good to be merged. |
ping @teacup-on-rockingchair : ) |
re :) I am working on a solution that would use profile interactive variable for this problem. |
Thanks for the update. All fine so. Take your time. :) Regarding this PR, I believe it is almost ready to be merged with minor changes in the platform, as I mentioned here. So, maybe it would be still valid to make these minor changes and merge this PR. Then you could open another PR to introduce this interactive variable. What do you think? |
ceac0cd
to
7923369
Compare
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Code Climate has analyzed commit 77390db and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.2% (0.0% change). View more on Code Climate. |
/packit build |
Description:
Rationale:
Review Hints:
Review hints here. Replace this text. Don't use the italics format!
Use this optional section to give any relevant information which could help the reviewer to more quickly and assertively understand and test the changes.
Good examples are useful commands, if it is better to review all commits together or in a suggested sequence, any relevant discussion in other PRs or issues, etc.