Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections in bash/ansible remedition of the rule audit_rules_privil… #11196

Merged

Conversation

rumch-se
Copy link
Contributor

…eged_commands_kmod

Description:

  • Fix is necessary because the rule does not work as expected on SLE 12/15

Rationale:

  • Because the rule uses template - ansbibe/bash remediation do not require sle

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Oct 12, 2023

Code Climate has analyzed commit dc9c0eb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 57.0%.

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Oct 17, 2023
@jan-cerny jan-cerny added this to the 0.1.71 milestone Oct 17, 2023
@jan-cerny jan-cerny added the SLES SUSE Linux Enterprise Server product related. label Oct 17, 2023
@jan-cerny jan-cerny merged commit 1abe48d into ComplianceAsCode:master Oct 17, 2023
37 checks passed
@Mab879 Mab879 added the Update Rule Issues or pull requests related to Rules updates. label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants